James Addison
James Addison
> > Modern web platforms often use URL-safe encodings in element IDs > > This seems to be unusual; I don't think that URLencoding content within an HTML document is...
> Ok; I may be mistaken about all of this. The HTML5 spec -- specifically the section with title ["Scrolling to a fragment"](https://html.spec.whatwg.org/multipage/browsing-the-web.html#scrolling-to-a-fragment) (7.4.6.4 in the version I'm reading, last-updated...
[Initially](https://github.com/sphinx-doc/sphinx/issues/13620#issuecomment-2963968170) I was apprehensive and uncertain that this should be considered a bug in Sphinx. That's because I didn't expect HTML documents to contain any percent-encoded content; I felt that...
Seems pretty reasonable, yep. We have an existing precedent for reporting links with a status code of `ignored` [when HTTP 5xx responses are encountered](https://github.com/sphinx-doc/sphinx/blob/cc1b13ccbfaa3c6818839f66d1bb0627203bd204/sphinx/builders/linkcheck.py#L569-L571); I'd suggest we use that same...
Ah, sorry; I read too quickly (as usual). I see that the desired behaviour would be a plaintext HTTP retry on failure. I'm going to think about that for a...
I'm in two minds about this; I agree that selectively bypassing the ingredient-consistency test could make sense for some scraper tests, and I think that the use of a key...
Those are all possibilities, yep! As [mentioned](https://github.com/hhursev/recipe-scrapers/issues/1062#issuecomment-2077346082) in the issue thread, the natural way to handle this would be by marking/overriding the relevant test case and skipping it in Python...
Thinking about it. For the scraper tests, there are currently two categories: * Data driven tests - most of them. * Legacy tests - tests for scrapers that use API/multi-HTTP-requests...
@mlduff I _think_ that's possible, yep, but I have to check if I understand the idea: is what you're suggesting somehow similar to the way that we dynamically create a...
Also, something to bear in mind: a benefit of data-driven tests is that it's possible for people to read the `.json` files and to check -- without having to know...