James Addison
James Addison
> In follow-up pull requests, the plan is to generate fixtures from genuine, buildable test Sphinx project sources included within this repository. This turned out to be less code than...
@picnixz when you have time, could you review this pull request next, and then #12107 after that? I know there are a lot of these small changes / PRs, so...
The latest changes in mainline make a small change to the `searchindex.js` file format. I'm going to apply a change here too (including merging in a [utility script](https://github.com/jayaddison/sphinx/commit/fbaff49c264640caefd190db3afc10b4cea6e406) that I've...
Thanks @wlach! I think I should re-test this manually after the latest merge; any additional code review feedback would be useful. I do remember that there was some JavaScript variable...
> Thanks @wlach! I think I should re-test this manually after the latest merge; any additional code review feedback would be useful. I do remember that there was some JavaScript...
Thank you @wlach for the code review! I've left a couple of not-entirely-resolved items open, and let me know what you think of the adjustments.
Thanks @picnixz - all done with those changes, so I think this is ready for merge.
Ok, I'm gradually beginning to understand this; I'll probably have a lot of questions. One of the next ones is: why do we need `TestRootFinder`? It seems to add a...
Big-idea question: is the testing plugin also intended for use by other projects (for example, themes) to test their builds, or is it mainly/entirely for use within Sphinx?
> > Big-idea question: is the testing plugin also intended for use by other projects (for example, themes) to test their builds, or is it mainly/entirely for use within Sphinx?...