James Addison
James Addison
Thank you @chrisjsewell!
Nope, not as easy as reverting a single-commit; I'll revisit this again later.
Question: will this mess with localization/translation workflows? Various `.po` files [refer to the template file paths](https://github.com/sphinx-doc/sphinx/blob/98f953e158a18101a50bbb30c3ecfbddc3eda4e6/sphinx/locale/ar/LC_MESSAGES/sphinx.po#L1158-L1160): ```sh $ grep -r '_t:' sphinx/locale | sort | head -n 10 sphinx/locale/ar/LC_MESSAGES/sphinx.po:#: sphinx/builders/latex/__init__.py:199...
If anyone with a security/sysadmin mindset could double-check and/or challenge my thinking in this thread I'd appreciate it: https://github.com/sphinx-doc/sphinx/pull/12364#discussion_r1663995437 Aside from anything related to that, I'm now comfortable that the...
Thank you! (including for the `removesuffix` fixup - a nice py3.9 benefit!)
I'll remove the shoutiness from the pull request description; that was written at a moment where I'd emerged from confusion about what the `supported_data_uri_images` flag on a builder means.
@chrisjsewell if+when you have time, I'd appreciate review on this changeset: * It resolves what seems like a regression: some output images began not to appear in (LaTeX builder) output....
Thanks @AA-Turner!
I've been investigating this, after recently [modifying](https://github.com/sphinx-doc/sphinx/pull/12274) some image-download code -- I was wondering if that could be related. It doesn't seem to be, but I'll report some findings from...
Another challenge: the [`C++` term in an existing test index](https://github.com/sphinx-doc/sphinx/blob/6af611ed85b3de3c5aa5a98bcb8cf9bb5d437aa9/tests/js/searchtools.js#L9) needs to be replicated if we follow this approach. The current EN-language stemmer maps the input term `C++` to `c`...