Jay Satiro

Results 293 comments of Jay Satiro
trafficstars

> I also found few other links where this exact issue was discussed in the past: Note the mailing list article does not appear to be the exact issue. >...

Can you use -DUNICODE -D_UNICODE instead

It seems [this](https://github.com/curl/curl-for-win/blob/559ca8b2adf594a33c3128e682be3b53f48e0b73/curl.sh#L53-L54) is the way curl-for-win does it: ~~~shell CURL_CFLAG_EXTRAS="${CURL_CFLAG_EXTRAS} -DUNICODE -D_UNICODE" CURL_LDFLAG_EXTRAS_EXE="${CURL_LDFLAG_EXTRAS_EXE} -municode" ~~~ So we'd have to apply -municode only for the curl tool? /cc @vszakats

> Maybe add a `./configure` option for Unicode build? Seems like a good idea. > (BTW: What is the difference between `CURL_CFLAG_EXTRAS` and `CFLAGS` variables?) I think it was added...

I don't see any downsides to changing it. The change below fixes it but then will also do it even if the login string is empty, for example `http://@test.com` ~~~diff...

Bisected to 7d600ad (#8451) which removed the user_passwd flag in favor of checking user pointer. AFAICT that means now that a username must always be set if a password is...

I was more at the concept phase. Does it make sense to check in override_login?

> I can confirm the patch fixes the issue. Thanks. I will look at turning the patch into a PR.

I couldn't get the docker working for this. If you have a step by step way to reproduce without docker I will try that.