Jay Satiro

Results 293 comments of Jay Satiro
trafficstars

> I'd prefer to document it as a known bug and explain the user may be able to use the `\\?\` prefix as a workaround. This issue has been documented...

> What happens if a too long name is set in the URL and then there is no `Content-Disposition:` header? curl fails, same as it already does when there's no...

> this PR might not change anything for that issue other than delaying the error a little. That issue is really two different issues. This PR fixes the one where...

Yes the AWS links are ephemeral so you'd have to generate a new one `curl.exe -fkLs -w "%{url_effective}" -OJ "https://github.com/curl/curl/releases/download/curl-7_81_0/curl-7.81.0.zip"` On Windows, before: ~~~ > curld -fkL -w "%{filename_effective}" -OJ...

I still think it's a good idea. I put off writing a test for it (and some other PRs as well), I will do that soon.

This could be a problem if homedir is expected in local encoding by some dependencies. For example, homedir() is used to pass the homedir to the ssh library: https://github.com/curl/curl/blob/6b951a6928811507d493303b2878e848c077b471/src/tool_operate.c#L1755-L1760 https://github.com/curl/curl/blob/6b951a6928811507d493303b2878e848c077b471/lib/vssh/libssh.c#L2224-L2232...

The latest iteration of this I've banned curl_getenv in the tool in favor of tool_getenv which maps to tool_getenv_local or tool_getenv_utf8. Similarly homedir which maps to homedir_local or homedir_utf8. The...

I redid it again to cover both libcurl and the curl tool. getenv, curl_getenv, curlx_getenv are banned in favor of Curl_getenv which maps to Curl_getenv_utf8 for Windows Unicode and Curl_getenv_local...

> Maybe late to note but OpenSSL _does_ support UTF-8 in default Windows builds (for filenames notably), in these cases, it'd be useful to keep strings in UTF-8. OpenSSL falls...

> Yeah, I've noticed (to my horror) that OpenSSL does have a fallback logic. But, UTF-8 is the primary encoding there and without it, it's only possible to pass non-ASCII...