Jason Ish

Results 234 comments of Jason Ish

`pl->h` is still passed onto `pcap_dump`, is its fully not written out to disk?

Given a rule with `reference:url,www.vpngate.net;`, I get the following logged: ```json "references": [ "http://www.vpngate.net" ], ``` what are the other possibilities? I guess I had expected something more like: ```...

> Think it could make sense to start splitting files into a categories early, ideally also making it optional to use certain parts. E.g., I added a Dutch national broadcasting...

> 3400000 That is correct, and this entry would be added to the SID allocation records if that is OK: ``` +| 3400000-3499999 | Aleksi Bovellan | https://github.com/aleksibovellan/opnsense-suricata-nmaps | ```

> Alright, sounds good @jasonish . I've now edited these rules to match the new "sid quota", and will continue doing so with my future stuff also. > > After...

Thanks for the contribution! Do you plan to make Suricata-Verify tests? Or have pcaps that exercise the new code that we could turn into tests?

Draft as I need to make this a dummy master somewhere to make sure all the variables make it through on a pull request, but likely good as-is.

Replaced by https://github.com/OISF/suricata/pull/11407.

> Commit messages : `dns parsing: add additional section` -> `dns: parse add additional section` ? Fixed.

https://github.com/OISF/suricata/pull/11433 allows a user to keep v2 for dns records.