Jason Ish

Results 234 comments of Jason Ish

Replaced by https://github.com/OISF/suricata/pull/11121.

> "geoip_src": { > "ip": "192.236.155.230", > "geo": { > "continent_code": "NA", > "country_iso_code": "US", > "city_name": "Seattle", > "country_name": "United States", > "continent_name": "North America", > "timezone": "America/Los_Angeles", >...

To summarize my thoughts in one place: > * Separate repo, released as a crate. Ideal, but this will make it hard to always build against the `main` branch. `Cargo.lock`...

> Is there a ticket for [fix serialization of nan and inf](https://github.com/OISF/suricata/pull/10775/commits/71f59e529c3ceaba977ec5d3492bb8b3d3184cd1) ? From the commit: https://redmine.openinfosecfoundation.org/issues/6921

Will close for now, until we have serde_json for some other reason.

/cc @amirabell as I can't assign or mark you as a reviewer.

The sample program does segfault on exit. `TmThreadKillThread` tries to join a thread ID of 0. This is due to the "fake" thread setup for user owned threads to satisfy...

> Yes, in library mode TVT_PPT threads should not be joined. Fixed in my local branch by not join "external" threads. Will be ready for review soon.

Replaced by https://github.com/OISF/suricata/pull/11711.

> @jasonish - how does this version look to you? Yeah, not as pretty :) But more future proof with respect for some changes I hope to have in by...