Jan Fajerski

Results 91 comments of Jan Fajerski
trafficstars

Hey @jackma-00 and @arejula27 feel free to propose a PR. Please note that there is already an open PR https://github.com/prometheus/prometheus/pull/14160. It seems to be orphaned but there is some context...

:+1: for having this feature. Left over salt jobs can be killed via `salt saltutil.kill_job ` or shotgun style `salt '*' saltutil.kill_all_jobs` iirc. The latter one might interfer with SUMA...

> Sorry for sprinkling the comments instead of doing them in one review. But I think I have addressed all questions now. Not at all, thanks a lot for your...

Fwiw this is for now just an attempt to revive code that Damien already wrote. I have not checked if revived code make sense in the current test setup. This...

This has to wait till the prometheus 3 dev branch is available.

@alex-kattathra-johnson Seems like you are also trying to merge the `main` branch here. Can you base your changes on the `release-3.0` branch please.

We have merge `release-3.0` into `main`. The base branch for this PR should be changed to `main` now.