James Liu

Results 429 comments of James Liu

Real fast attempt applying this just to bevy_transform and bevy_time, found some quick blockers. - `std::borrow::Cow` only exists in std, no `core` equivalent exists - The lints fire on the...

Credit should be given to @lassade, @The5-1, and @Toqozz for their prior work in this space. Could you add `Co-Authored By: ` to the PR description? Bors will merge it...

@devil-ira #5619 seems to be addressed by this. Can you add `Fixes #5619` to the PR description?

As in those tests pass even in the base #93 without this fix? Or that this PR doesn't fix those tests?

> #6817 similarly abstracts the deferred mutation pattern, but seems to do so in a fully compatible way. The main difference here is that this is a standalone type. It's...

> This could be avoided by replacing the `get` method with a `scope` method that takes a `impl FnOnce(&mut T)` similar to how the existing ParallelCommands impl works. I personally...

> main thing for me to approve is just to see a bench that check_visibility still performs the same. Comparing `many_cubes` on main vs this PR, it does seem like...

Adding to 0.10.1 as this is useful to anyone using UI and is non-breaking.