James Liu

Results 428 comments of James Liu

I'm also not sure a UI display for this is the most apt approach since this is always compiled in. We may want to instead expose spans or counters to...

Going to leave this open until the ordering issue is resolved. See https://github.com/bevyengine/bevy/issues/1255.

This may have an impact outside of just user-facing events. Since #7713, this also impacts component removal: https://github.com/james7132/bevy_asm_tests/blob/9fd5f20e252f6e4401d352a0b675098d7e010aff/results/entity_remove.s#L2340-L2356

When setting up the benchmarks for #8251, I found nearly 5x improvements to event sending. Didn't impact event iteration. ``` events_send/100 time: [90.729 ns 95.492 ns 101.49 ns] change: [-79.753%...

Removing the controversial label as the RFC has been merged. I'll update this PR and address the comments as soon as I can.

bevyengine/rfcs#51 is the RFC in question, which was written to be independent of the primitives RFC and has been merged. I'll probably rewrite the primitives RFC when it comes time...

> Ok, this was confusing because the PR description only talks about [bevyengine/rfcs#49](https://github.com/bevyengine/rfcs/pull/49) and says this PR implements it (which looks to be the case), while there's no mention of...

For posterity, the discussion that led to this being merged can be found here: https://discord.com/channels/691052431525675048/774027865020039209/1202358388466384956

For thread-local, https://github.com/Amanieu/thread_local-rs/pull/76 should handle this without pushing past 1.63. Note that the MSRV policy in the README states last 3 versions of stable Rust, which would put a cap...

@InBetweenNames can you please mark in the PR description that this `Fixes #6161` so that it gets auto-closed when this is merged? I'll give this a review soon. This has...