Jacob Walls

Results 432 comments of Jacob Walls

@DanielNoord Have you tested this with namespace packages? Will it be a problem that `is_namespace()` is cached in `astroid`?

I guess I was wondering if we should be doing less caching: if a module name that was cached by astroid's` is_namespace` may or may not be a namespace depending...

> I'm not sure if we should do this. As long as astroid can't pass mypy I'm not truly comfortable that all of our typing is correct. Might be better...

> By adding py.typed we signal that we think that our current typing is at least correct and can only be expanded to include additional signatures, but I wouldn't be...

We knew there was a risk of causing this false positive in https://github.com/PyCQA/astroid/pull/1622, but I thought we checked that we handled it (I suppose not). Closely related to #1630 (might...

Let's just relax the check to allow `__index__` calls. The spirit of the check as I took it was to replace obvious things like `__len__` with `len`, not deal with...

Thanks for the report. Those two tests create a command line string to pass to `py_run`, but if the temp dir contains a space (yours did), they will fail, because...

Thanks for the report. We could probably close all of the `NewType` issues as duplicates of #2296. We need `astroid` to know that NewType callables return instances of the parameter...

I'd like to provide input, but the fall is going to be very busy for me. I'm not sure when I'll have the time to take a look. I'm very...