Jack Matthews

Results 11 comments of Jack Matthews

I managed to fix it using the following ``` javascript var fn = googleObject['get' + capitalize(this._cfg.name)]; if(fn) { val =fn(); } else { val = false; } ``` I can...

Is there not a limit on the length of a query string? What would happen when the models exceeded this length?

Also need to escape characters in the header so that =, [, ] characters can be used

In theory a check for a single error could happen here: https://github.com/origin-energy/java-snapshot-testing/blob/master/java-snapshot-testing-core/src/main/java/au/com/origin/snapshots/SnapshotContext.java#L91-L101 I'm not sure we'd want to do it though and it might be able to be done another...

I would be happy for a PR that achieves this. Just needs to remain backward compatible.

It seems that this might be a bug in the JUnit Jupiter API `BeforeAllCallback`. When I run the test by itself, it correctly returns the current class name calling `context.getTestClass()`....

I have a test for this is sure enough, expect is part of the nested class https://github.com/origin-energy/java-snapshot-testing/blob/master/java-snapshot-testing-junit5/src/test/java/au/com/origin/snapshots/NestedClassTestWithExtends.java#L28

I'd be happy for this to be added to java-snapshot-testing-jackson as an additional Serializer. Would you consider a PR? Some comments: - Probably don't want to convert to a list...

I have implemented this as part of https://github.com/json-snapshot/json-snapshot.github.io/pull/23. You would be able to do `expectScenario()` for each iteration with a unique identifier per scenario.

The reason for shadowing was to make the inclusion of this library simpler. It was also used to ensure version clashes don't occur between project and test libraries. Agree though...