ivmarkov

OK. I would still defer to the other committers for opinion. If they are for it - I'm fine with removing this one line - `esp-template` - for one -...

The problem is, the eth RX callback is badly documented, in that who owns the buffer is not even mentioned. So I assumed the usual rule where the caller of...

Two notes: * C_str is an ``ESP-IDF-ism, so we should avoid it here (`embedded-svc` does not assume there is a C implementation underneath), as this is an API leak. *...

@jmesmon Do you still plan to work on this and address my comments?

> Fixes #337 Also fixes the conversion of ssid/password in the config to no longer assume 0 termination - this lead to problems when routers send a 64 byte access...

I've delayed merging this for way too long, and now it has a conflict. :( @torkleyy if you don't have time or will to resolve the conflicts in this PR,...

BTW, I'm worried that we might have other places to fix: specifically, the _reverse_ conversion of native SSID into `heapless::String` SSID. But these we can of course fix later.

Thank you!

> @ivmarkov I would need some advice, log2 is not available in std but would be required for the calculation, I could do this with ilog2, but then I have...

> Additionally, since the naming is confusing. The boolean connected in the embedded_svc::mqtt::client::EventPayload::Connected(connected) actually represents session_present. This flag serves as an indicator for the client, informing it whether a previously...