ivmarkov

Results 702 comments of ivmarkov
trafficstars

This should be fixed. PRs welcome! Background: All drivers should be `Send` but currently few (if any) are `Sync`. We can actually also do the latter too for most drivers...

> Possibly related upstream issues: [espressif/esp-idf#11097](https://github.com/espressif/esp-idf/issues/11097) ~~I don't think this link is related at all to the issue you are describing, and what you are describing sounds like a gross...

Actually, I checked the bug twice and I'm changing my mind. There's a chance that it *might* be the root cause, I just can't believe it happens **on the first...

BTW I'm digressing, but... [this loop will block the HTTP server from processing anything else besides your just-created web-socket](https://gitlab.com/IvanSanchez/solanera/-/blob/main/src/webserver.rs?ref_type=heads#L139). Reason: the ESP IDF HTTP server is *single threaded*.

> > **how severe the problem is actually** > > After realizing my fumble with the WS loop, I'm not fully sure. But having a WS handle do work on...

> > > After realizing my fumble with the WS loop, [...] > > > > > > You are mixing up things. > > What I meant to say...

Yeah. These are the dangers of using glob-imports (as in `use esp_idf_sys::*`). As the content of the module you are importing might change, you are risking name conflicts. In that...

Oh, and you can of course always just temporarily patch `esp-idf-hal`'s `adc` module and rename the `resolution` var in there to `resolution2` or something, but I'll of course never upstream...

> Thanks for this! In my case option 2 is probably the best. How is this different from using `bindings_module` in the `extra_components`? (which doesn't seem to solve the problem)...

Limited access to internet right now. Will follow up when I have an opportunity