iotex-core

iotex-core copied to clipboard

[api] Support tx signed by ledger

1

fix #2916 Extra data field `EncodingType` is added into the legacy tx struct, which aims to differentiate txs signed from ledgers.

Liuhaai

### What would you like to be added - Step 1: create `xrc20totalsupply.go` and `xrc20totalsupply_test.go` files in `./ioctl/newcmd/action`. create this directory if not exist. - Step 2: refactor command https://github.com/iotexproject/iotex-core/blob/master/ioctl/cmd/action/xrc20totalsupply.go...

huof6829

# Description Merging coreservice and chainservice. Quite a few features inside of chainservice may not be appropriate, but it is out of the scope of this PR. In addition: 1....

CoderZhi

**What would you like to be added**: - separate producerPrivKey from config.yaml - have a new yaml file, e.g., privkey.yaml, for this field **Why is this needed**: For now, chain.producerPrivKey...

raullenchai

add test case that `Add(-1) Sub(-1)` would fail

1

add test case that `Add(-1) Sub(-1)` would fail _Originally posted by @dustinxie in https://github.com/iotexproject/iotex-core/pull/3401#discussion_r879993927_

CoderZhi

Move config definition into corresponding components

5

Right now, most of the configs of different components are defined in config/config.go, and config is used in different components. As a result, the dependency is very complex that loop...

CoderZhi

**What would you like to be added**: Load `config.SetEVMNetworkID(cfg.Chain.EVMNetworkID)` in `main.go` in a proper way

Liuhaai

**What would you like to be added**: https://github.com/iotexproject/iotex-core/blob/master/blockchain/integrity/benchmark_test.go#L173 **Why is this needed**:

Liuhaai

**What would you like to be added**: Add unit tests for db/trie/mptrie/branchnode.go **Why is this needed**: Enhance implementation

CoderZhi

**What would you like to be added**: Add unit tests for db/trie/mptrie/leafnode.go **Why is this needed**: Enhance implementation

CoderZhi