Elliot.
Elliot.
@nbougalis could you resolve the merge conflict and clang-format?
I merged `develop` and applied clang-format.patch. If acceptable to you, @nbougalis , this PR will be squashed when it is merged, so it's OK to leave the merge commit for...
We had a comparable situation with https://github.com/XRPLF/rippled/pull/4192: the PR author recommended keeping the commits as-is, and so we did. Later, we learned there was some discontent with that, and that...
blocked: let's get some agreement on whether this PR should end up as 3 commits, or 1. If it's 3 commits, I think it would be best to open a...
@seelabs confirmed 3 commits for this is fine. I am rebasing the commits individually to ensure they pass CI on GitHub. If they pass, I will merge them no earlier...
Suggested commit message: ``` Avoid using std::shared_ptr when not necessary: (#4218) The `Ledger` class contains two `SHAMap` instances: the state and transaction maps. Previously, the maps were dynamically allocated using...
will merge after github checks pass, if I don't hear any objections
@manojsdoshi to try to corroborate the 15-22% memory use reduction Released in 1.11.0.
Proposed solution: https://github.com/XRPLF/rippled/pull/4566
Example: https://livenet.xrpl.org/transactions/97FD0E35654F4B6714010D3CBBAC4038F60D64AD0292693C28A1DF4B796D8469 Appears to affect all reporting mode servers.