Elliot.
Elliot.
Just needs conflicts to be resolved @HowardHinnant . There is no need to rebase (although that is fine if that's what you prefer) - merge commits are OK since they...
I don't know if it's intended, but if that's how it currently is, then I see no strong reason to change it.
> 1. You could add tests to this pull request or > 2. I could submit a pull request that adds tests for Memo. > > I've written such tests,...
@RichardAH what's your preferred path forward for this PR?
Suggested commit message: ``` Introduce in-development Hooks amendment (#4225) * Hooks V2 squashed from https://github.com/XRPL-Labs/xrpld-hooks/tree/006524a10aa406d09742dae69a9cf271bdea0d26 * Include changes from code review Introduce "Hooks" functionality with the new SetHook transactor. This...
@nbougalis please review Howard's suggestions above, at your convenience.
@scottschurr can you confirm whether your concerns have been resolved?
I checked with @scottschurr and we agreed that he has no particular need to review this PR, and we think it would be best to assign a different reviewer in...
@seelabs confirmed this is ready to merge. When merging: - merge conflicts should be resolved - the clang-formatting should be fixed
@drlongle just FYI since this was discussed with Mark today. This PR isn't blocking on your review, but please feel free to have a look and share any questions/comments.