Ian Flanigan

Results 61 comments of Ian Flanigan
trafficstars

Besides the comments above (and the problem with the CLA), this looks fine to me. If you need to send a new pull request with the changed commit user, just...

There's a problem with the commit authorship. I believe this is because the commits were made with one email address, but the github PR was made with another. When @amralassal...

I'm pulling in the [latest changes](https://github.com/google/closure-stylesheets/commits/review-2018-07-02) from the internal repo so that you can rebase this change on top of them. Then I'll pull it internally and re-push.

My two reviewers have had a lot going on, so they haven't had time. I pinged @seanmfoy and he says that he'll get to it this week.

Reported by `[email protected]` on 2011-12-02 22:15:53 - **Labels added**: Type-Enhancement - **Labels removed**: Type-Defect

``` This is something very great moving forward with more modern browsers in the playing field. Where does this enhancement stand as of today? ``` Reported by `[email protected]` on 2012-09-19...

While this does fix the problem, I think it's doing it by not including the given input renaming map, which seems wrong. Instead, we have to be sure that we...

You are correct. We should implement support. Any volunteers?

Reported by `[email protected]` on 2011-12-02 22:16:04 - **Labels added**: Type-Enhancement - **Labels removed**: Type-Defect

``` This would be very helpful. While I prefer the closure ant configuration with fine grained settings per group, it might also be worth taking a look at the wro4j...