Ian Flanigan

Results 61 comments of Ian Flanigan
trafficstars

Awesome! :-) I actually don't have any recommendation for how to implement it at the moment. Some of the linters that I've seen are just a bunch of regexps and...

Yes, we would definitely like to have this as a feature. It is just not built yet. If you're interested in developing it, let me know.

Hi James, Looking at `::slotted`, it seems to have pretty [specific semantics](https://drafts.csswg.org/css-scoping-1/#slotted-pseudo). Generally, from what I see, it's pretty hard to predict what should go in a pseudo element, so...

(And by "do that", I meant "review the code".)

Hi there, I can't think of a reasonable way of testing this, so I think your change is fine as-is. If you sign the CLA, then I'll pull the change...

I'll try right now and get back to you.

`mvn package` works for me from head. Here's how it ends: ``` none [INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ closure-stylesheets --- [INFO] Building jar: /Users/flan/Projects/closure-stylesheets/target/closure-stylesheets-21060712-SNAPSHOT.jar [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO]...

So true! Let me fix that right now.

I've created a branch called `mvn-runnable-jar` that has the changes. You can create the JAR with: ``` shell mvn clean compile assembly:single ``` I'm not committing that to `master` yet...

This has been asked for several times, so I'm thinking that it's not an unreasonable request. One of the reasons that we haven't done things like this in the past...