Krzysztof Ostrowski

Results 90 comments of Krzysztof Ostrowski

Firstly, I want to apologize for the delayed response on this. We value your contribution and think that this feature could be beneficial. However, we're currently in the midst of...

Summarized here: https://github.com/brancz/kube-rbac-proxy/issues/238

Oh, that is a cool contribution. I will take a look, but first I will take a look at the bug introduced with the last version.

I don't think so, just patience 😅 I was waiting for @stlaz, but he said that it is fine to merge. But there is no hurry yet as there are...

@lucacome , actually I just watched a best practice in a talk at KubeCon London: Could you pin the full commit hash of the current checkout v4 ([11bd71901bbe5b1630ceea73d27597364c9af683](https://github.com/actions/checkout/commit/11bd71901bbe5b1630ceea73d27597364c9af683))? It is...

I agree, we will need to change that :) If you have any best practices to share, you are welcome, otherwise I would make it part of the release cycle,...

The e2e tests are failing :) Sorry, for not approving you earlier, but once I press the "approve" button, your PR gets merged automatically once it is green.