Krzysztof Ostrowski
Krzysztof Ostrowski
> @ibihim the code related to (2) appears to have changed since the pre-acceptance review as it's no longer on [`brancz:sig-auth-acceptance`](https://github.com/brancz/kube-rbac-proxy/blob/sig-auth-acceptance/cmd/kube-rbac-proxy/app/kube-rbac-proxy.go#L76-L94). Could you double-check whether it still applies please? If...
> @ibihim (12) seems to not apply anymore; nesting has been simplified in the latest version in [`brancz:sig-auth-acceptance`](https://github.com/brancz/kube-rbac-proxy/blob/sig-auth-acceptance/cmd/kube-rbac-proxy/app/kube-rbac-proxy.go#L217-L226). Could you please verify? Yes, the nesting seems to have been gone....
> @ibihim link for 17 points to the task/link for 16 -- does 17 maybe refer to [this block](https://github.com/brancz/kube-rbac-proxy/pull/229/files#diff-8796db11a6b137095413f7a7109dd01393e63d425454fc04647b98d2b8c0115cL317-R329) instead? Yes, I think so. Sorry. The markdown with all the...
> FYI I do not have permissions to edit the issue description therefore I can't tick off any checkboxes :/ You can enumerate the tasks you've done in a comment....
Did you test the changes? Bumping some deps doesn't work: https://github.com/brancz/kube-rbac-proxy/pull/283, it must be part of a bigger k8s bump.
I've looked into the topic, and there aren't any clear solutions available. While there's a filter for logging, it only applies to the message content. It doesn't seem possible to...
Hi, I've seen this issue long time ago, but never came back to it. Sorry for the delay. I will try to take a look next month. This is a...
Hi, I will take a look, but CVEs in dependencies that are not within the code path of kube-rbac-proxy are not a priority. kube-rbac-proxy doesn't use any instrumentation itself. I...
@changluyi, your PRs are not working. It would be nice if you could at least check if it builds.
Should be fixed with https://github.com/brancz/kube-rbac-proxy/pull/287