Ian O'Connell

Results 109 comments of Ian O'Connell

I think I'd rather we make a storehaus-contrib's repo and move these sorts of stores there. Any upgrades to support new scala versions to the core get blocked on lots...

Sounds pretty cool. I believe redis can support it via its scripting API. But not sure of any other ones that could. (Scripts are executed atomically, so you could return...

If you look in chill and summingbird we have code around only including modules for 2.10

I think twin source for now makes the most sense with eventually being a standalone project in one or a 3rd repo. You can iterate quickly as you work more...

From https://github.com/twitter/summingbird/blob/develop/summingbird-online/src/main/scala/com/twitter/summingbird/planner/OnlinePlan.scala#L194 this looks like its not supported i think/is the expected behavior. Thats probably the location to fix too

(i think conceptually what you have requires creating multiple merge nodes, I don't think we generated any new nodes in planning before which is probably what this hits)

Yep I think that's the likely fix here. Some tests/rules will need special casing but it does seem like logically what we want to do. (This applies to flat maps...

Looks good to me, though would love to see a test to keep our coverage up.

I haven't looked at any of this code in 2years or more, so this could be nonsense... but.. https://github.com/twitter/summingbird/blob/develop/summingbird-online/src/main/scala/com/twitter/summingbird/planner/OnlinePlan.scala#L180 I think looks like it could cause what your seeing. It...

Could do with a description indicating what it output before vs now?