Ian O'Connell

Results 109 comments of Ian O'Connell

I think the requirement I was thinking of is a bit looser, with the logic: 1. If a type is registered now but wasn't earlier, then the classname is inline,...

The modulo iirc was due to the fact that spreading the key over the full range creates separate keys for ~most things to hadoop/scalding. which means some things like iterator...

One thing on a code perspective, given shapelesses tighter requirements around scala versioning and adding another dep I think it would make sense to move this into a scalding-shapeless module....

Should we re-visit this now since 0.17 is out?

The suffixTemplate should just have a "/" to start it, then it will operate fine. (Its how the source is used generally). We should put a require statement into the...

you could add the require to the body of those classes. It will do the check as part of instanciating it then I think

Ok I think this is looking a bit more cleaned up and may be worth looking at again design wise. I'd be slow to merge this as-is if we think...

Have you looked at the matrix 2 API?

It seems like an intresting project, probably a decent bit of work. But a good experiment. Quantifying the win from the perf aspect seems tough enough too. (personally since I...

So if you just sub-class ScaldingShell, say you want to provide a default config or do some arg parsing of your own before handling to the ScaldingShell. You'll currently get...