Pieter Hoste
Pieter Hoste
The two static test failures that remain (see below) will be fixed when coding-standard v25 will be used in the automation here like [explained earlier](https://github.com/magento/magento2-page-builder/pull/777#issuecomment-1164768101), no idea why version 25...
Rebased on latest `develop` branch (or should we now use `future-develop`??) And removed my silly workaround for static test failures, now that https://github.com/magento/magento-coding-standard/issues/409 is resolved finally (the tests will probably...
Rebased on latest `develop` branch, let's run the tests again, now that coding-standard 32 got released some weeks ago with a fix for a false positive that kinda blocked this...
@magento run all tests
@paras89: are you still around? Any chance you (or one of your colleagues) could pick this up soon-ish so we can get this included in Magento 2.4.7? Thanks!
@engcom-Hotel: what needs to happen to move this PR further? It has been open for 2 years and fixes an obvious problem.
And it landed today, in version 2.0.4, this issue can be closed now I guess, @Stoyvo?
@sidolov: it looks like [your fix](https://github.com/magento/composer-root-update-plugin/commit/dcbfe8b121b7767443c33289e0ab0173117771bb) hasn't been released yet? Latest published version is 2.0.3 (also on repo.magento.com), [the fix (and some other commits)](https://github.com/magento/composer-root-update-plugin/compare/2.0.3...develop) haven't been published yet in a...
The fix for PHP 8.2 has finally been released today in version 2.0.4: https://github.com/magento/composer-root-update-plugin/compare/2.0.3...2.0.4
It looks like some commits got added to 2.4-develop branch yesterday that will probably fix this, see: https://github.com/search?q=repo%3Amagento%2Fmagento2+float+comparison+precision&type=commits Unfortunately this wasn't done in a single merge commit, those got mixed...