Pieter Hoste
Pieter Hoste
@sidolov: any chance the priority can get increased here? It's not only a simple cleanup like you think it would. If you use [a module to change the less compiler...
@paras89: done! (I've rebased my changes on top of `develop` instead of having merged `develop` into my branch, which results in a cleaner git history, but the end result is...
Most failures in the static tests are probably going to be fixed by upgrading the coding-standard library to version 25 (ref https://github.com/magento/magento-coding-standard/pull/405 & https://github.com/magento/magento-coding-standard/issues/395), and the failures that will remain...
@paras89: I don't really think this is the right move here, shouldn't the coding standards be changed so it allows underscores? It's not like this will ever go away in...
@paras89, @sivaschenko: any input on my remarks? Especially around: > shouldn't the coding standards be changed so it allows underscores? It's not like this will ever go away in the...
@paras89, @sivaschenko: any update from you regarding my question(s) would be appreciated. Thanks! 🙂
Just to move this PR forwards, I've added some coding standard ignore directives. I really don't like it because: - the code looks incredibly ugly, makes it hard to read,...
It looks like an issue for this has already been created in the coding-standards repo: https://github.com/magento/magento-coding-standard/issues/409, in typical Adobe fashion, it has been ignored for 2 months already
@magento run all tests
@magento run all tests