Holger Drewes

Results 507 comments of Holger Drewes

Update: ah, and I guess I really want to have all the tests working before we merge anything here, no matter on the explanation why tests eventually fail. Then we...

Ugh. I've now idea why this is not starting? 🤔

Hi there, thanks for the PR! 🙂 Could you please give some more context and explain what you are doing here?

Not sure if I find some time but if so would it be ok to directly push some additional tests to the dependency-update PR https://github.com/ethereumjs/ethereumjs-wallet/pull/25?

Hi @stvtortora that's nice, thanks for the offer! 😄 Please be aware of this open PR https://github.com/ethereumjs/ethereumjs-wallet/pull/86 from @chikeichan. We forgot a bit about that unfortunately, but would be nice...

I think this might be a valuable addition to the API, yes.

@axic Is it really so easy to read things from memory with JavaScript?

Hmm, that's the same with all libraries, theoretically you can use/access all (most) parts of the code but are encouraged to engage with the methods which are part of the...

Hi Jacky, sorry that this never got merged. Would it be ok if I take the code parts with the tests of your PR manually and integrate into the updates...

Hi @chikeichan, would really be happy on an answer here 😀 (see comment above), otherwise I would need to close which would be a bit a pity. All the best...