ethereumjs-wallet icon indicating copy to clipboard operation
ethereumjs-wallet copied to clipboard

Published 20 hours ago • verified publisher icon ethereumjs

Add test for fromV1

Open chikeichan opened this issue 6 years ago • 5 comments

Relates to #26

Adding a few missing negative tests. Much of the remaining missing coverage seem to be from the _typeof polyfills.

chikeichan avatar Mar 05 '19 03:03 chikeichan

Coverage Status

Coverage increased (+5.6%) to 94.774% when pulling 0a5b8ad34f916f287e71c9c4e5ac2709aa2ac0f4 on chikeichan:increase-coverage into 830307cb1b4d083a469e796e2c34064a6c948479 on ethereumjs:master.

coveralls avatar Mar 05 '19 03:03 coveralls

Hi Jacky, sorry that this never got merged. Would it be ok if I take the code parts with the tests of your PR manually and integrate into the updates TypeScript test files? Or would you alternatively even have some time to update the PR?

Hope everything is fine, all the best Holger

holgerd77 avatar May 09 '20 11:05 holgerd77

Hi @chikeichan, would really be happy on an answer here 😀 (see comment above), otherwise I would need to close which would be a bit a pity.

All the best Holger

holgerd77 avatar Sep 15 '20 10:09 holgerd77

(I know it is an absurdly late reaction here, but from the current PoV this is the only thing I can do)

holgerd77 avatar Sep 15 '20 10:09 holgerd77

Hi Jacky, sorry that this never got merged. Would it be ok if I take the code parts with the tests of your PR manually and integrate into the updates TypeScript test files? Or would you alternatively even have some time to update the PR?

Hope everything is fine, all the best Holger

Hi @holgerd77 - hope all is well! please fell free to take the code parts with the tests and integrate. Cheers!

chikeichan avatar Sep 15 '20 21:09 chikeichan