Hadrien Milano

Results 49 comments of Hadrien Milano

I believe you can just use `reader.close()` instead of manually consuming the output in a thread. @samsieber's fix in #31 is better IMO.

Hi, This should not be a problem unless some dependency isn't compatible. Have you tried building RösHTTP with the proper ScalaJS version? You could submit a PR and we'll see...

Hi, I am not actively working on this project currently. Happy to help if you submit a PR though.

Thanks @mathieuleclaire . I really mean to spend the time to fix the CI setup, but this is a huge pain in the ass, and I am not working on...

Yes, there is a companion server to run alongside the tests on localhost. It's all explained in [contributing.md](https://github.com/hmil/RosHTTP/blob/master/CONTRIBUTING.md#testing).

Version 3.0.0 should work with Scala.js 1.x. Let me know if there's a problem.

Hi, thanks for the feedback. How about using the constructor function with a relative url? ```scala HttpRequest("/this-relative-endpoint").send() ```

Hmm.. That's not right. We should not allow requests to be constructed with a `null` host, because then the request's `url` is garbage. The "withURL" method needs to change. It...

Thanks for this insightful feedback. As of v2, I am no more actively working on the library. Contributions are more than ever welcome and I am willing to provide support...

There might be great potential to address this issue using [netty](https://netty.io/) or akka. These backends are asynchronous which means they behave more like JS networking. Thus using such backend could...