Harrison Healey

Results 190 comments of Harrison Healey

Can you check that this doesn't cause any issues with refreshing the app with Playbooks backstage open or opening the expanded view for Calls? I don't think I actually tested...

Yeah, I agree that this might be a bit niche for us to include. Instead of adding `setUrlVersion` or needing to make your own copy of `Client4` though, I think...

@isacikgoz @agarciamontoro I think there might be some misunderstanding here still. The TTFB measurement that the we app reports is indeed a proper TTFB, but it's the TTFB for the...

@agarciamontoro The code that reports it is [here](https://github.com/mattermost/mattermost/blob/master/webapp/channels/src/utils/performance_telemetry/reporter.ts#L115), but the calculations are all done by either the browser itself or by [the Chrome team's `web-vitals` library](https://github.com/GoogleChrome/web-vitals). There's very little that...

Thanks for the PR, @everhopingandwaiting! Sorry for the wait on reviewing this. Is your PR still needed now that https://github.com/mattermost/mattermost/pull/27419 has gone in? I think that may have fixed the...

Sorry, @xy371661665. This is already being worked on. This ticket is a duplicate of https://github.com/mattermost/mattermost/issues/15975

Thanks again for fixing this, Ashish, and thanks for the help testing this, @Rutam21!

> @hmhealey I have added a feature flag but it seems some active development is going on the settings tab. Should we keep replacing old tabs if possible? By "replacing...

This looks great so far. I have a bigger suggestion for reorganizing the components for individual settings sections within a tab, but most of the other stuff I commented on...

@calebroseland I hadn't heard about `AbortController` or `AbortSignal` until now. Want to talk about them in a web guild or dev meeting at some point? The name seems pretty self-explanatory,...