Harrison Healey

Results 207 comments of Harrison Healey

That's strange. I would've expected that to work, but perhaps something else is missing. Could you push those changes so that I could try them out? They can either be...

@hanzei I'm not sure who your team usually assigns to QA test your tickets, so I assigned @yasserfaraazkhan. If there's someone else who'd be better to test it, feel free...

Looks like that that's complaining about the order of the translation strings being wrong. I can update that. **Edit:** If you're ever needing to do it yourself, you can run...

@abhijit-singh Let me know if there's any changes you'd want to see from a user perspective, particularly around the timing the bar appears, the text on the bar, and whether...

> @hmhealey if I reject the permission, i.e, disallow it, the notification banner never shows up. I just want to confirm this is intentional. Yeah, that's intended. The browser also...

Oh right. Sorry, I totally forgot about that case since you definitely mentioned that before

@abhijit-singh I ended up just removing the z-index from that component entirely since, as far as I can tell, that hasn't been needed for a long time. I think that's...

Yeah, those are both expected. For the first one, we can't prompt the user to change their permission if they've previously blocked it, so I don't bother showing the bar....

> Come to think of it, it looks good to make a new PR about YouTube Shorts layout. Should I revert the commit? Yeah, if you could revert it and...

> I reverted it! Should I made the issue to make new PR for shorts? Yeah, please do. If it needs the changes in this PR as well, you can...