Marcel Hellwig

Results 96 comments of Marcel Hellwig

So this exploded a bit. It went from 5 to 31 commits, but yeah, it may be easier for you to review, I can understand that. I removed the fmt...

I try to resolve the issues. I see some concerns and I think thats ok. Everything you think is not worth changing or might be bad can be annotated by...

I think that was a good idea, so no worries :) Rebased. I think at least https://github.com/rust-itertools/itertools/pull/618/commits/bf2c114c859023c16ead2d5ebb77d5063c4a91f9 should be pulled in as well, but we can do that later. Without...

Done :) I very much thank you for your patience and effort you put into this! It's not easy to review this kind of stuff. Many, many thanks! Btw: I...

Rebased again. Take your time, I'm not in a hurry

I tried with https://github.com/stm32-rs/stm32l4xx-hal/pull/61 to simplify the `into_afxx` functions. @nickray is your link still valid (can you please use the "copy permalink" feature next time, which will link to a...

I want to add, that this warning is not enabled for the `BIT` instruction. `BIT #$20` is not warned, although it depends on the `m` flag

and maybe a `From` and/or `From

The thing is, currently I'm feeling that I'm writing some old style rust code where I have: ```rust fn main() { if let Err(e) = run_real_main() { ... } }...

Honestly, I don't think that a proc macro would be a good idea here. How would you combine that with e.g. `#[tokio::main]`? What about the idead from https://github.com/shepmaster/snafu/issues/333#issuecomment-1136289313 to use...