Marcel Hellwig

That's a lot of (good) code. I think for now providing a "proper" `Debug` implementation would help and would work for a lot of older rust versions. I think this...

While #137 was merged and resolves the issue with `rcc.rs`, other places are left: ``` rg 'Into' -n src/sdmmc.rs:502: pub fn init_card(&mut self, freq: impl Into) -> Result { src/sai/pdm.rs:183:...

More examples: https://github.com/lupyuen/stm32bluepill-mynewt-sensor/blob/f51e0784957723fcea8d3efaec10cbaacd1d8048/src/send_coap.rs#L34-L37 https://github.com/lupyuen/stm32bluepill-mynewt-sensor/blob/f51e0784957723fcea8d3efaec10cbaacd1d8048/src/listen_sensor.rs#L30 https://github.com/lupyuen/stm32bluepill-mynewt-sensor/blob/f51e0784957723fcea8d3efaec10cbaacd1d8048/src/listen_sensor.rs#L70 (why is that one declared as `extern` although it's not `pub`?) https://github.com/lupyuen/stm32bluepill-mynewt-sensor/blob/f51e0784957723fcea8d3efaec10cbaacd1d8048/src/send_coap.rs#L20 https://github.com/lupyuen/stm32bluepill-mynewt-sensor/blob/f51e0784957723fcea8d3efaec10cbaacd1d8048/src/send_coap.rs#L34 and finally you can convert the integer error codes to an enum...

> Here's different pattern for returning results No, that's not returning a `Result` (as you can see by the return type). It's just returning a struct. > Also what do...

I hope you are compiling with `--release`. `expect("")` should be `expect("start_network_task failed")` or similar. https://docs.rust-embedded.org/book/start/panicking.html could help

Personally, I would not avoid using a `Result` even if that means, that by binary increases by a few kb. > warning: unused `std::result::Result` that must be used That's the...

~~How does this differ from the original lua scripts?~~ Okay, it only differs by the GetModImage function. My solution should be "the better one", because it makes it possible for...

awesome, thank you :heart:

Arch Linux

Thanks! Would this something for the readme?