Hezekiah M. Carty

Results 100 comments of Hezekiah M. Carty

That looks good to me! The ppx removes/centralizes most of the potential for typos in the codebase, so it's nice to have that much flexibility in nesting. I like it.

One approach I've used when a C binding needs to have all operations run in the same thread under `Lwt_preemptive` is to create a long-lived thread which does the initialization,...

If it helps - using an older 4.08.0 installation, also using fdopen's opam distribution, I don't get a segfault. On 4.10.0 I do get it.

One downside to swapping is that it breaks with how other conflicts are handled between syntaxes.

It might be nice to save `->` for Reason's core syntax later on. It's not a valid infix operator currently. The previously cases of swapping for keywords caused confusion before....

A user pointed out that `++` is not currently handled properly when converting from OCaml to Reason (see https://reasonml.chat/t/access-conflicting-infix-operator/805). Could that be captured in this fix as well?

@anmonteiro I think so, at least for infix operators.

This seems like a nice simplification, with the downside that keeping the `\`-prefix form in the AST makes conversion to/from OCaml syntax harder.

@anmonteiro Sorry, I was thinking of Reason -> OCaml through ocamlformat since refmt doesn't keep comments. I don't think ocamlformat is perfect in that regard either, to be fair. And...

@IwanKaramazow Unfortunately not. Going `.re -> refmt -> ocamlformat` translates the syntax but last I checked refmt drops comments when outputting OCaml syntax.