Sebastian Pipping

Results 734 comments of Sebastian Pipping
trafficstars

@asyncee thanks! Looks like the transition worked, see https://github.com/asyncee/django-easy-select2/pull/97 .

@afinetooth coveragepy-lcov is an interesting pointer. Thanks for elaborating :pray:

@afinetooth we have moved away from `--service=github` (and `GITHUB_TOKEN`) to `COVERALLS_REPO_TOKEN` as suggested [in the mean time](https://github.com/asyncee/django-easy-select2/pull/97/files) and now today [we're getting](https://github.com/asyncee/django-easy-select2/runs/5087340738?check_suite_focus=true) error `coveralls.exception.CoverallsException: Running on Github Actions but GITHUB_TOKEN...

Hi @afinetooth thanks for your reply! I had a look at the [causing code in coveralls-python](https://github.com/TheKevJames/coveralls-python/blob/c35bf51671a9608b6b5610e61a1510bf1924882c/coveralls/api.py#L55-L59) now. Because it's detection centers around variable `GITHUB_ACTIONS`, I have decided to [take that...

@afinetooth I think you're arguing for `--service` over variables. Let me think about that.

Idea: Pin this issue and close #134 as a duplicate?

@thaogit if this issue matters to you, please make it a complete bug report, there are hardly enough details to start try reproducing the issue, yet. Thank you.

@MChetanSR please provide more details (like a backtrace, a minimal reproducible example file, details about versions and the environment) to make this a proper bug report. Right now, it doesn't...

I'd expect `SVGFigure(width=1000.0, height=1000.0)` to raise `AttributeError`which is handled at https://github.com/btel/svg_utils/blob/10a082008a40a387cd80ef044c3efe6a8aa79bd6/src/svgutils/transform.py#L244 . Which version of svgutils are you running?