Sebastian Pipping

Results 785 comments of Sebastian Pipping

> So probably the cleanest solution is to reject all tests where either a, b, or delta are not finite. :+1: > // Coypright (C) 2020 Peter van Hoof Glad...

So now that we seem to agree on how to move forward: There is no way you're going to make a pull request for this?

@pvh513 if you don't want to use GitHub UI you could also just download the repo and/or file and use GNU diff, name the output `.patch.txt` and attach that file...

@pvh513 should this be closed as "good enough for now" or is there still interest to improve on this subject?

Git tags recovered from release tarballs now. For verification, something like ``` diff -u -r cpptest cpptest-1.1.2/ | fgrep -v '$Id:' | grep '^[+-]' | grep -v '^\(+++\|---\)' ``` worked...

@robertcragie I would like to bring this pull request to your attention: https://github.com/libexpat/libexpat/pull/577

@adanaher you asking with regard to openleadr-python or Expat? Expat >=2.4.7 has a fix.

@adanaher that's probabably a question of the underlying Docker image or Linux distro release in your context, a question of environment. How and where are you installing openleadr-python?

@adanaher have you checked your installed version of package `libexpat1` using `apt-cache policy libexpat1` in the image? Debian 10 is [buster and has `2.2.6-2+deb10u4`](https://packages.debian.org/buster/libexpat1) with [change log entry "lib: Relax...

> @hartwork I was able to install version 2.2.6-2+deb10u4. Should that in theory fix the problem? @adanaher I would expect so, yes.