Harsh Singh

Results 47 comments of Harsh Singh

Hi @guillim I see there is no update yet. So, I would like to work on this. ![Image](https://github.com/user-attachments/assets/88c5d9fe-cc5e-466d-8044-f1a34a77f3b0) 1. The `Select` component already accepts `withSearchInput`. So we can directly use...

@guillim Sure! I will take a look at this tomorrow and will let you know which could be the best solution to tackle both the issues.

@guillim I looked into this again and I still think that using `MenuItemSelect` instead of `MenuItem` in the `Select` component is a better choice. Here is why: 1. First of...

@guillim I don't see it anymore. I'm on the main branch. Can you recheck from your side? ![Image](https://github.com/user-attachments/assets/b1f812b9-05f3-493f-adb6-22d41a7c543d)

@guillim I made a PR here #9179 Sorry for the delay! I was busy with personal work. But I will be active from now onwards :)

@charlesBochet I need your review on this.

> > Fixes: #7460 > > ![Screenshot from 2024-10-14 15-27-52](https://private-user-images.githubusercontent.com/26953022/376202037-bbae5c6f-0b36-4f98-92c5-de27b1eb06ad.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjkyNzExODEsIm5iZiI6MTcyOTI3MDg4MSwicGF0aCI6Ii8yNjk1MzAyMi8zNzYyMDIwMzctYmJhZTVjNmYtMGIzNi00Zjk4LTkyYzUtZGUyN2IxZWIwNmFkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDEwMTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQxMDE4VDE3MDEyMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQ3NjJlMTJhYjlhMjI1ZmI4ZmU0N2Q5MjNkODQzODU2YTI4ZmU2MjEyN2VkNjlmNzA5ZmFjNWFlNjg5N2ZmNjMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.vm82cGIlHsoSZDDsZ_gdui8d7N8_DqX-GJGr83nljPE) > > Thanks for contributing @harshrajeevsingh! Can you remove the `Error Occured` page title? Yeah! I will remove it. @lucasbordeau...

> > @Bonapara Should we implement this not only in settings but everywhere in the app ? > > CleanShot.2024-10-18.at.19.02.25.mp4 > Don't we already do this? @Bonapara I don't think...

@Bonapara Do we need that view bar, too? I think it's better to throw errors for that whole container. If any error occurs in viewBar, too, it will show the...

@lucasbordeau what should be passed in header of both RecordIndexError & RecordShowError fallback and how? For now, I just gave a temporary title. ![Screenshot from 2024-10-23 00-45-43](https://github.com/user-attachments/assets/d23d7bcd-9a04-4d0d-b8e5-68cd474400a5)