Guilherme Janczak

Results 53 comments of Guilherme Janczak
trafficstars

Other place with the same pattern: https://github.com/resurrecting-open-source-projects/scrot/blob/3b281dbf20fb4e4b8bd74c177163c441561db024/src/selection_edge.c#L152-L158 This one seems similar on the surface: https://github.com/resurrecting-open-source-projects/scrot/blob/5ef8a82612a57ebd8b70cc45eaea437cbcfed741/src/scrot_selection.c#L248-L256 But I don't know if there's a way to sleep until the keyboard can be...

I think the difference between `-D` and the `DISPLAY` environment variable is an unintended consequence more than a feature. Are people really going to run scrot in one X server,...

It'll still remove and simplify code if we keep the lines that get the display name from the environment for `scrotGrabShotMulti()`. Shouldn't be too hard. We don't have to fix...

https://repology.org/project/imlib2/versions Requiring very recent versions of things causes 2 issues to my knowledge. It often makes it difficult to develop, one might need to figure out how to compile imlib2...

Yeah, this fork's source was imported improperly. Someone else has a fork that does have a proper history: https://github.com/dreamer/scrot I wonder if we can steal any bug fixes from that,...

scrot has a lot of code that wasn't very well thought out, that's why we can rewrite it shorter, more portable, faster, etc, so often. There isn't really a reason...

`dpi / 75 + 1` should be fine.

No, sorry. I'm reading instead of programming at the moment.

I think the current state of the code is more important than the past state of the code. Scrot at some point had no style, lots of dead or useless...

Declarations at the top are a nice summary of what's in the file, specially if they're ordered properly because that also gives an idea of the call graph. C is...