scrot icon indicating copy to clipboard operation
scrot copied to clipboard

remove undocumented --focussed spelling of --focused

Open guijan opened this issue 2 years ago • 4 comments
trafficstars

Fixes a small part of #272. Wikitionary says "focused" is the common spelling in the Commonwealth and the US: https://en.wiktionary.org/wiki/focussed although "focussed" is recognized as valid.

guijan avatar May 20 '23 19:05 guijan

This has been in scrot since 2009, 1e90918ca2191a8322ac80ba04b2bd7e0e3c87dc (the commit date doesn't match up, I presume because it was manually imported to git from some other source control system).

I think I'd just leave it be and document it instead.

N-R-K avatar May 22 '23 06:05 N-R-K

Yeah, this fork's source was imported improperly. Someone else has a fork that does have a proper history: https://github.com/dreamer/scrot I wonder if we can steal any bug fixes from that, or if we can fix our history.

guijan avatar May 23 '23 22:05 guijan

I wonder if we can steal any bug fixes from that

Probably worth investigating. Also if that fork is actively maintained, we should maybe try to unify efforts instead (unless that fork has philosophy/goal incompatible with ours).

if we can fix our history

This will end up changing the commit hashes of pretty much the entire repository. Which will break some (a lot?) of automated setups (e.g package managers).

And even in general, a repo changing it's entire commit history overnight is incredibly suspicious from an outside perspective (especially so for package maintainers).

N-R-K avatar May 24 '23 09:05 N-R-K

Seems like that person wasn't planning to maintain/develop that fork: https://github.com/dreamer/scrot/issues/2#issuecomment-537611069

N-R-K avatar May 24 '23 10:05 N-R-K