Oli

Results 525 comments of Oli
trafficstars

I noticed we were missing the type `lnrpc.OutputScriptType_SCRIPT_TYPE_WITNESS_V1_TAPROOT` for wallet transaction outputs of the `GetTransactions` RPC. Added a commit and itest case for it.

Just a quick side note here that these are both streaming APIs and you should use [WebSockets](https://github.com/lightningnetwork/lnd/blob/master/docs/rest/websockets.md) for them. That likely explains the EOF error. The `illegal base64 data at...

I guess it's a bit weird indeed if you just look at the REST API. But because REST is just a wrapper for gRPC, it inherits its patterns. Basically every...

Sorry for the late feedback, I should have commented on https://github.com/lightningnetwork/lnd/issues/5402 earlier. I think we want to keep the protos in the same place as they currently are, for the...

You don't need to have any node synced as the tests all run on a separate regtest network anyway. So just having the binaries installed should be enough for the...

Did you install a version of `bitcoind` with ZMQ support enabled?

As mentioned before: > Also, some of the unit and integration tests are a bit flaky, so they sometimes fail without a change being the cause for it.

What I forgot to add but is kind of the whole point of the PR is: We should make `lnrpc` its own go module and reference it in the main...

Creating a new go module is the whole point of [the original feature request](https://github.com/lightningnetwork/lnd/issues/5402). The point is not to avoid downloading things from Git but to massively reduce the linked...

Wait, I don't think we're talking about the same thing. You moved the server code out of `lnrpc` so the package only contains the gRPC definitions. All that's left to...