Oli
Yeah, you're right. That's a lot of data. And I think I found the bug. We write to the `batch-replay` bucket [here](https://github.com/lightningnetwork/lnd/blob/master/htlcswitch/decayedlog.go#L404) but we apparently never delete from it. That...
I'm going to change the title to indicate this is a bug.
I took a closer look again as well. And to me it looks like the data persisted in `batch-replay` is used in `PutBatch()`. When storing a batch, we first check...
Yes, I saw your PR. But I don't think we can delete the bucket, we need it to make sure a batch of packages wasn't relayed before.
> As migrating/GCing the old data seems rather expensive to me, would it be viable to just delete the sphinxreplay.db or empty the offending batch-replay bucket once? I would not...
Yeah, those two RPCs don't seem to bubble up their changes to the main [`cfg`](https://github.com/lightningnetwork/lnd/blob/8adec8692ad2b8e1d1a4023c56ccc6db8ddcce76/rpcserver.go#L603) struct of the RPC server, which should be quite trivial to fix.
You're looking in the wrong place, what you linked to is the Command Line Interface. You'll want to take a look at the server implementation here: https://github.com/lightningnetwork/lnd/blob/789c6bac8ca4b75d15e9e40f8ded8e394df518bb/lnrpc/routerrpc/router_server.go#L948 That then seems...
The "Check commits" CI step succeeded locally, probably just too many commits for GitHub.
!lightninglabs-deploy mute
> I can see there are some merge commits as I was trying to update my branch. Would that be a problem? I am trying to figure out how to...