Oli

Results 531 comments of Oli
trafficstars

@itshig this error shown above sounds like an issue with the UI (RTL or Voltage UI?) itself, trying to fetch channel information to display, then not showing the buttons because...

You need to split the `channel_point` into its two parts: ``` lncli closechannel --funding_txid 1bae01e863444d89f5d3612ed27adc5f1553396f16feb774a0dbba93d7632805 --output_index 1 ```

> I think fee estimation _within_ the main daemon (so the sweeper, and funding inputs, etc) should be correct however. Yeah, I did a code sweep and searched for all...

`make install` will put the binary in your `$GOPATH/bin` directory. So look for an `lnd` binary there, and put your `$GOPATH/bin` to your `$PATH`.

Thanks for picking up this PR! I think you should attribute the original author in the commits. At least those that you took over more or less unchanged.

> I will now pick up the work from @guggero's last change requests -> https://github.com/lightningnetwork/lnd/pull/4029#pullrequestreview-866128472, try and make CoinSelectUpToAmount more legible and add the requested tests. Sounds good to me!...

> @guggero If the open channel is being invoked with a psbt(e.g. for a specific UTXO) and fundmax flag is specified, is it possible to open the channel with just...

@hieblmi thanks a lot for the updates. I'll take a look at the PR some time soon. About your questions: > whther or not we should add an integration test...

> In step 2 the creation of the funding transaction is then supposed to consume the total of the specified inputs without change output minus fees/ reserve etc.? Yes, that's...

> Thanks for the review @guggero - would you also be able to comment on my questions above about a new test case and the `psbt`/`fundmax` behavior? --> [#6903 (comment)](https://github.com/lightningnetwork/lnd/pull/6903#issuecomment-1254996287)...