Guillaume Toison

Results 231 comments of Guillaume Toison

Thanks for the clarifications @Moritz5432 I think it would help a lot if you could provide a Kotlin sample where `EI_EXPOSE_REP` is expected (you have already provided one where it...

Hello, thank you for reporting the issue, that change is not intentional. I attempted to reproduce the problem here: https://github.com/spotbugs/spotbugs/compare/master...gtoison:spotbugs:issue-3492 but this seems to work as expected. I'm also surprised...

Thanks for the clarifications, would you be able to share a minimal example reproducing the problem?

It looks like your `@SuppressFBWarnings` was suppressing the `UWF_UNWRITTEN_FIELD` in an unexepected way. When an "unknown" annotation is on a field `UWF_UNWRITTEN_FIELD` is not reported because that field might be...

We probably want to raise a warning for every unclosed Autocloseable at some point but the current code tries to do a bit more, for instance keeping track that a...

SpotBugs analyzes the compiled .class file, so it doesn't know how it was produced/compiled. Lombok adds another layer of complexity here and it would be easier to comment on the...

The bug description says that it might be a bug and that the code might be confusing: _This method performs synchronization on an object that is an instance of a...

In general SpotBugs does not do inter procedural analysis, i.e. it analyses methods separately and wouldn't be aware that other methods might access the field from another thread (let alone...

Constant values seem to be specifically ignored when looking for dead stores, I'm not quite sure why TBH: https://github.com/spotbugs/spotbugs/blob/d5602766acb22de9b04ff817d7e752b79ebcfbf5/spotbugs/src/main/java/edu/umd/cs/findbugs/detect/FindDeadLocalStores.java#L403

One way would be updating the `@SuppressFBWarnings` annotation, adding a `matchType`: ```java public @interface SuppressFBWarnings { String[] value() default {}; String justification() default ""; SuppressMatchType matchType() default SuppressMatchType.DEFAULT; } public...