Guillaume Toison

Results 231 comments of Guillaume Toison

Can you check (or share) the `.class` file? I guess that the Graal compiler could potentially add some asserts for methods annotated with `@CEntryPoint`

Thanks, I definitively need to educate myself about Graal 😄 I looked a bit into how SpotBugs detects `ASE_ASSERTION_WITH_SIDE_EFFECT_METHOD` and it seems to be looking for "setter like" method calls...

I've pushed a commit here: https://github.com/gtoison/spotbugs/tree/issue-3483 I don't think the change will break something but at this point it's only a wild guess

Thanks for trying this out! I attempted to build graal myself but seem to run into issue with the native part, I get this error in the build report: ```...

Thanks, you can also try to throw an exception instead of resetting the `inAssert` in `visitAfter(Code obj)` Again that's just a guess but apparently the expectation of the author was...

I understand Kengo's sentiment that a pure immutability would be better, but that ship has sailed: we're using heuristics to detect immutability. Maybe in the future we'll be able to...

My understanding of the code is that it looks for methods doing `throw new UnsupportedOperationException(...)`., the code does not look for methods _declaring_ that they throw `UnsupportedOperationException`

My understanding is that the methods are analysed separately, so when analyzing your `foo`, `bar` or `baz` methods SpotBugs is not smart enough to see that the calls to `getString("xyz")`...

Is it really unzipping the file? I was under the impression that this all happens in memory, meaning that it does not write the unzipped content in a local file.