Guillaume Raille

Results 16 comments of Guillaume Raille

Have you made sure your attribute values are unique ?

there are several development improvement by using this approach. The fact that the IDE is within the container means that you don't need to work with potentially slow mounted volumes,...

since support for elasticsearch has been dropped maybe the section of the doc about it should be dropped as well: https://docs.saleor.io/docs/integrations/elasticsearch/

Fixes #1732 Fixes #782

> @grll Nice work! Looks like we still have some failing tests, let me know if you'd like some guidance there. > > As for the code, can we please...

> +1 this is nicely done. > > @grll @DouweM what do you think about having a GCRA implementation as implemented by something like https://github.com/ZhuoZhuoCrayon/throttled-py ? > > It's a...

> > > +1 this is nicely done. > > > @grll @DouweM what do you think about having a GCRA implementation as implemented by something like https://github.com/ZhuoZhuoCrayon/throttled-py ? >...

@DouweM or @dmontagu any thoughts on the above?

> @ZhuoZhuoCrayon Thanks a ton, throttled looks great! > > > > @grll Are you up for changing this PR to use throttled instead? > > Sure happy to!

@ZhuoZhuoCrayon thanks for the reminder, busy times. I am on it now! I will switch throttled and fix the CI :)