Thomas Grainger comments

Repositories
Issues
Comments

Results 965 comments of


                                            Thomas Grainger

Drop python3.8 support

I don't think this is a good first issue. There's lots of fiddling around with linters involved

avoid holding a reference to exception and value in to_thread_run_sync

> This seems like just reimplementing `outcome`. If you need to copy, why not instantiate `outcome.Value`/`Error` directly? Only detail that's different is `unwrap` doesn't clear values, but we could just...

avoid holding a reference to exception and value in to_thread_run_sync

@TeamSpen210 https://github.com/python-trio/outcome/pull/45

remove reference to value/error when unwrapping outcome

could just call it InvalidatingOutcome, InvalidatingError and InvalidatingValue

remove reference to value/error when unwrapping outcome

> Would using a weak reference not be acceptable? I think that would be more complicated and it would be odd that unwrapped values are sometimes there sometimes not and...