Thomas Grainger
Thomas Grainger
I'm a bit concerned about how the pyopenssl context is configured. I think this would break `httpx.get(..., verify=cafile)` Generally SSL in httpcore is configured by passing in a SSLContext but...
I think the way to do it is move `httpx.create_ssl_context(` into httpcore then add an http3 kwarg that makes it return a dataclass with both an ssl context and a...
I've been thinking about this for a while and using two different contexts for the same httpx session is cryptographically fishy (and probably slow - loading the cert store twice)....
I've misunderstood how tls in aioquic works, I saw the dep on pyopenssl and made the assumption it's used for TLS. However aioquic uses it's own TLS 1.3 implementation which...
> Pointers? ?
@webknjaz could you for now build and upload the docker image, narrowing the window for a compromise and speeding up usage of the action?
> @graingert publishing to GHCR is now implemented. Hooray!
@samskiter oh that's odd, it's using the AsyncIOBackend on trio, can you post your blah.py source code?
Copying my analysis from: https://github.com/python/cpython/issues/125502#issuecomment-2413536175 the problem occurs when asyncio.runners._cancel_all_tasks is run at an inopportune instant when connecting pipes: This task gets cancelled: https://github.com/python/cpython/blob/92af191a6a5f266b71373f5374ca0c9c522d62d9/Lib/asyncio/base_subprocess.py#L56 which means self._pending_calls is never run:...
@kumaraditya303 I think the fix is to use: ```python self._waiter = waiter self._task = task = self._loop.create_task(self._connect_pipes()) task.add_done_callback(self._wake_waiter_and_call_pending_calls_or_close) ``` Then in `def _wake_waiter_and_call_pending_calls_or_close(self, task): ...` check the exception/done/cancelled state of...