Results 961 comments of Thomas Grainger

I don't like the name "gonna_run_dask", however once "cleanup" had this new name it was obvious to me which tests didn't need it, so clearly the new name is better,...

It's particularly frustrating here because 127.0.0.1 doesn't actually need to use a thread to resolve it because it's already resolved: * https://github.com/python/cpython/pull/31497 * https://github.com/tornadoweb/tornado/issues/3113

this was first fixed in the specific case of interpreter shutdown: * https://github.com/dask/distributed/issues/6087

How about ``` with contextlib.closing(self.comm.write( payload, serializers=self.serializers, on_error="raise" )) as gen: yield gen ```

> @graingert want to make a PR for that? Can you make it, I don't have the bandwidth right now sorry!

blocked by https://github.com/dask/distributed/pull/6854

breaking ground on enabling this refactor here https://github.com/dask/distributed/pull/6836 I think we can both require `async with Client(asynchronous=True):` and still keep `client = Client(asynchronous=False)` working because the async context manager version...

My usecase for these testing utilities is kind of subtle, I like to be able to make changes to the testing infrastructure to increase strictness I also like to be...

As an aside it's really painful for us to add new fixture dependencies to our 'exported' fixtures because they need to be re-imported completely in a way that appears to...

> I wouldn't consider them to be public to users necessarily, but certainly they're public to other dask libraries and other friends-of-dask like Xarray. From my perspective those libraries are...