Kenta Goto (k.goto)
Kenta Goto (k.goto)
This would have nothing to do with this PR. However, it would be curious to know if this is just a coincidence or if it happens with other PRs. It...
I approved, but the PR doesn't have the label. Could you run PR Linter again?
Could you try making some changes to the description of this PR without running CodeBuild CI?
It appears that the status is `CHANGES_REQUESTED` and the `communityApproved` is false even though it has been approved: https://github.com/aws/aws-cdk/actions/runs/10669155243/job/29570426536 ``` raw data: { "go-to-k": { "id": 2225629631, "node_id": "PRR_kwDOBk6Df86EqGm_", "user":...
@ren-yamanashi Hi, the fix PR has been merged! https://github.com/aws/aws-cdk/pull/31290 I approved it again and the review label was successfully attached.
This is an excellent suggestion. It would be especially nice to have the built-in validation in L1 by default. And most of my opinions have already been mentioned above. Introducing...
@nmussy You're absolutely right (I hadn't really thought about it properly...). I have corrected it as such.
The CodeBuild run under the CommandsAction. But I don't automatically add the permissions for source services with `CODEBUILD_CLONE_REF` (`codeBuildCloneOutput=true`). https://github.com/aws/aws-cdk/blob/v2.161.0/packages/aws-cdk-lib/aws-codepipeline-actions/lib/codebuild/build-action.ts#L189-L211 https://github.com/aws/aws-cdk/blob/v2.161.0/packages/aws-cdk-lib/aws-codepipeline-actions/lib/codestar-connections/source-action.ts#L158-L159 Because an error occurred in the CommandsAction with `CODEBUILD_CLONE_REF`....
@GavinZZ I am not sure if the document has changed since I saw it or if I was mistaken, but I have changed the policies to match the document. https://github.com/aws/aws-cdk/pull/31667/commits/8b8c5d7c17bf7864819309ee7be7f64580024071...
~~I'm investigating the CI failure because it creates differences in snapshots.~~ It seems to have been fixed after full build with the latest commit in main branch, soI will run...