Kenta Goto (k.goto)

Results 31 comments of Kenta Goto (k.goto)

@GavinZZ Thanks for your approval. It seems that the label `pr/do-not-merge` is attached, could you please handle this?

@TheRealAmazonKendra Have you had a chance to look at the PR? I would be glad to get your opinion if you have any.

@TheRealAmazonKendra @GavinZZ Hi, how is this going now?

@TheRealAmazonKendra @GavinZZ If it takes a little more time, could you put the `do-not-close` label on this PR and [the other one](https://github.com/aws/aws-cdk/pull/29127)? Otherwise, it will be automatically closed. > This...

> Oh... failed... Succeeded! I'll check them.

+1 I too hope this issue is resolved.

I would like to address this issue. However, [the CodePipeline API](https://docs.aws.amazon.com/codepipeline/latest/APIReference/API_StageDeclaration.html) has this feature, but [CloudFormation](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-codepipeline-pipeline-stagedeclaration.html) does not yet. So we are waiting for the CloudFormation property. (However, [the user...

The property (`OnFailure`) appears to have been added to CloudFormation and to L1. I will start on my PR. https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-codepipeline-pipeline-stagedeclaration.html https://github.com/aws/aws-cdk/pull/30182

I approved it, so it should have a `pr/needs-maintainer-review` label, but apparently it doesn't. Could you try to pull diffs from the main branch?