Glenn Jacobs
Glenn Jacobs
> can you add a test to ensure model events are more triggered twice when extended > > example: `App\Models\Product` extends base model > > in current implementation, when a...
> > Get the class from the original model > > > > > > ``` > > > \Lunar\Models\ProductType::modelClass(); // App\Models\ProductType > > > ``` > > > >...
Replaced by #1661
@netzknecht are you intending to finish this PR, or should it be ready for review now? Thanks.
Closing as this PR has had a status of "Draft" for a long time and our focus is now moving to 1.x.
Imagine the scenario below... You buy 10 mastic tubes and get a free mastic gun. The "Get Y" product(s) are different to those that qualify them in "BuyX".
Ah yes, that doesn't seem correct. I don't know why Qualify Products was added, I guess it was before the product limitation was added. So we either don't use limitations...
In terms of the code behind the scenes, I think it makes sense to reuse the Limitations system. However, the wording in the UI may not be ideal. So we...
Hopefully, we can come up with wording that suits both discount types. Will have a think!
> All tests are passing when using PHP 8.3.  Thanks for confirming. This issue is mainly about updating the GitHub Action workflows so they test against 8.3 and probably...